-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix GH-19720: Assertion failure when error handler throws when accessing a deprecated constant #19723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...essing a deprecated constant When deprecation causes an exception, we should return NULL instead of continuing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 8.4 we should have a test with E_STRICT so that it can be run without needing zend_test, and for 8.5 we would then also be able to confirm that the attributes don't mess with things, but the extra test can be done as a follow-up after this gets merged
For 8.4 we should have a test with
E_STRICTso that it can be run without needingzend_test, and for 8.5 we would then also be able to confirm that the attributes don't mess with things, but the extra test can be done as a follow-up after this gets merged
The fact that it can use attributes is not really relevant. The ZEND_ACC flag matters, not how it was set.
I prefer to just test this via zend_test, sure we can test via E_STRICT but once E_STRICT is removed we would be forced to change the test again to use a different constant in the test.
When deprecation causes an exception, we should return NULL instead of continuing.