-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Deprecate driver specific PDO methods #19596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3044969 to
776cfa2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annoying that we can't just add it to the fake stubs, but this alternative makes sense to me :)
Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RM approval, technical review not performed
Small question inline in my capacity as someone working with gen_stub, but this is approved regardless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh? Why not? Can you expand no this a bit?
If the support from gen_stub is missing I can try to add it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've expanded a bit when replying to @mvorisek above: #19596 (comment)
Possibly we could improve that a little by adding support for attributes to zend_function_entry, expose a function that copies zend_function_entry attributes to a zend_function, and use that in pdo_dbh.c.
This implements the "Deprecate driver specific PDO methods" part of https://wiki.php.net/rfc/deprecations_php_8_5.
Constants were handled in #19526.