Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix typos in code #19366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Girgias merged 1 commit into php:master from alexandre-daubois:typos-in-code
Aug 4, 2025
Merged

Fix typos in code #19366

Girgias merged 1 commit into php:master from alexandre-daubois:typos-in-code
Aug 4, 2025

Conversation

Copy link
Member

@alexandre-daubois alexandre-daubois commented Aug 4, 2025

No description provided.

@alexandre-daubois alexandre-daubois changed the title (削除) Fix various typos (削除ここまで) (追記) Fix various typos in code (追記ここまで) Aug 4, 2025
@alexandre-daubois alexandre-daubois changed the title (削除) Fix various typos in code (削除ここまで) (追記) Fix typos in code (追記ここまで) Aug 4, 2025
Copy link
Member

devnexen commented Aug 4, 2025

Looks ok in first glance, but I think lexbor and the JIT changes need to be ported towards their respective upstream repositories.

Copy link
Member

Girgias commented Aug 4, 2025

A bunch of these are from bundled libraries and should be fixed upstream:

alexandre-daubois reacted with eyes emoji

Copy link
Member Author

Oh alright, I was not aware of that. I pushed to only keep this repo related changes, I'll have a look to update other ones upstream. Thanks!

Girgias reacted with thumbs up emoji

@Girgias Girgias merged commit 433c00b into php:master Aug 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil-tekiela kamil-tekiela kamil-tekiela approved these changes

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@kocsismate kocsismate Awaiting requested review from kocsismate

@nielsdos nielsdos Awaiting requested review from nielsdos

@devnexen devnexen Awaiting requested review from devnexen devnexen is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /