-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Deprecate returning non-string values from a user output handler #18932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate returning non-string values from a user output handler #18932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for tackling this! I added a few comments and I think the reason you don't get the "correct" name for anonymous functions should be fixed with #19011
And update tests
8144c55 to
198a391
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits, but looks mostly good :)
There was reason why we didn't merge this: See https://externals.io/message/124506#124666 . @DanielEScherzer have you considered all those edge cases?
I think this should get another RFC that will in more detail consider output handler behavior.
Or lets leave it as you put already some effort into this and we will see how it goes. It was strange edge case anyway and might be a bit unusual for people to do that.
https://wiki.php.net/rfc/deprecations_php_8_4