-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix GH-13264: fgets() and stream_get_line() do not return false on filter fatal error #18778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@github-actions
github-actions
bot
added
Extension: sqlite3
Extension: standard
ABI break
labels
Jun 5, 2025
... filter fatal error This happens because there are no checks in php_stream_fill_read_buffer calls. This should not fail always but only on fatal error so special flag is needed for that. Closes phpGH-18778
@bukka
bukka
force-pushed
the
stream_gh13264_filter_fatal_err
branch
from
June 5, 2025 17:50
ae4ee72 to
b85429e
Compare
@bukka
bukka
changed the title
(削除) Fix GH-81475: fgets() and stream_get_line() do not return false on filter fatal error (削除ここまで)
(追記) Fix GH-13264: fgets() and stream_get_line() do not return false on filter fatal error (追記ここまで)
Jun 5, 2025
nielsdos
nielsdos
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is right. I also double checked no assignments to eof = 0; were missed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens because there are no checks in php_stream_fill_read_buffer calls. This should not fail always but only on fatal error so special flag is needed for that.