-
Notifications
You must be signed in to change notification settings - Fork 7.9k
CI: change MySQL image in CI from 8.3 to LTS 8.4 #18555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One mysql test fails, because mysql_native_password is not enabled by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because
mysql_native_passwordis not enabled by default.
It should be loaded then. Since it's still available, it makes sense to me that we still test it.
it needs command:--mysql-native-password=ON
It should be loaded then. Since it's still available, it makes sense to me that we still test it.
@TimWolla plugin is not even tested in this failing test case. It's test for mysqli_report() function. Plugin mysql_native_password is removed in PHP 9.0. It may be even wrong to consider this deprecated mode in tests because somehow the non-existing user uses deprecated auth, but we don't set it anywhere in the tests. It should be the default taken from mysql settings, that for 8.4 is caching_sha2_password.
plugin is not even tested in this failing test case. It's test for mysqli_report() function.
I see. I did not check the test. The change to ext/mysqlnd/mysqlnd_enum_n_def.h is a functional change, though. And thus unrelated to this PR. It makes sense to me, but it should have its dedicated PR including its own tests. As an example, I can't say whether or not it will break older MySQL 5.x versions.
Also caching_sha2_password requires linking mysqlnd against OpenSSL to work, which is not a given as of now:
php-src/ext/mysqlnd/mysqlnd_auth.c
Line 965 in 7e956f8
This reverts commit eccfaa2.
Please see:
#14118
Due to unstable behavior in authentication with MySQL 8.4, we were using 8.3 in our CI.
We need to check whether this issue has been resolved.
MySQL 8.4 is LTS version so I changed the version from 8.3 to 8.4 in the CI images.
https://dev.mysql.com/blog-archive/introducing-mysql-innovation-and-long-term-support-lts-versions/