-
Notifications
You must be signed in to change notification settings - Fork 7.9k
gen_stub: ZEND_ACC_NODISCARD is for PHP 8.5+ #18465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DanielEScherzer
DanielEScherzer
requested a review
from kocsismate
as a code owner
April 29, 2025 22:57
Cross link #17599
@DanielEScherzer
DanielEScherzer
requested review from
TimWolla and
kocsismate
and removed request for
kocsismate
April 29, 2025 22:57
@DanielEScherzer
DanielEScherzer
force-pushed
the
stub-NoDiscard
branch
from
April 30, 2025 01:25
44ad6c0 to
dac1b2e
Compare
@DanielEScherzer
DanielEScherzer
requested a review
from derickr
as a code owner
April 30, 2025 01:25
@DanielEScherzer
DanielEScherzer
force-pushed
the
stub-NoDiscard
branch
from
April 30, 2025 01:41
dac1b2e to
9b3b222
Compare
@DanielEScherzer
DanielEScherzer
force-pushed
the
stub-NoDiscard
branch
from
April 30, 2025 01:54
9b3b222 to
a993e63
Compare
TimWolla
TimWolla
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't try to understand all of the changes, but the changes to the arginfo LGTM. Leaving the final approval to Mate.
kocsismate
kocsismate
approved these changes
May 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a small nit
Co-authored-by: Máté Kocsis <kocsismate90@gmail.com>
@DanielEScherzer
DanielEScherzer
merged commit May 4, 2025
940ee1a
into
php:master
8 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.