-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fixed GH-18458: Authorization set with CURLOPT_USERPWD with NULL va...
#18460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@devnexen
devnexen
force-pushed
the
gh18458
branch
from
April 30, 2025 04:27
45d7d13 to
9030bb0
Compare
@devnexen
devnexen
force-pushed
the
gh18458
branch
from
April 30, 2025 19:01
09489dd to
1c25577
Compare
The code seems right. Did you also check what other options, besides the 2 mentioned in the issue, need this treatment?
likely a few more, I ll check later.
nielsdos
nielsdos
approved these changes
May 2, 2025
ext/curl/tests/gh18458.phpt
Outdated
@@ -0,0 +1,33 @@
--TEST--
GH-18458 authorization header is set despite CURLOPT_USERPWD set to null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
GH-18458 authorization header is set despite CURLOPT_USERPWD set to null
GH-18458 (authorization header is set despite CURLOPT_USERPWD set to null)
and add CURLOPT_PASSWORD to the mix. CURLOPT_XOAUTH2_BEARER already handled.
@devnexen
devnexen
force-pushed
the
gh18458
branch
from
May 2, 2025 19:37
d172938 to
a7b6008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...lue.