-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix GH-18148: pg_copy_from() wrong \n offset check. #18149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a comment for why this is +2?
@rperske
rperske
Mar 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the input string does not end with a linefeed, space is required for the input string plus a linefeed plus the final nul byte.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
She probably got it :) it was more a request than a question I believe, so we do not forget months later.
76929f0 to
2bcb3f1
Compare
rperske
commented
Mar 26, 2025
Thank you so much for your ultra-quick fix!
No description provided.