-
Notifications
You must be signed in to change notification settings - Fork 8k
sapi/cli: Print non-default INI settings for --ini=diff
#17762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a follow-up for php#17459, updating the command-line flag to not modify the behavior of `--ini`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not exactly sure how opt parsing works TBH. If Jakub doesn't review soonish I'll go and dig into the code to properly understand it.
Looks good to me. (An alternative might be to add --ini-diff.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
This is a follow-up for #17459, updating the command-line flag to not modify the behavior of
--ini.see https://externals.io/message/126303