-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix GH-16314 "Pdo\Mysql object is uninitialized" when opening a persistent connection #16369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kocsismate
kocsismate
requested review from
SakiTakamachi,
devnexen and
NattyNarwhal
as code owners
October 11, 2024 12:18
@kocsismate
kocsismate
force-pushed
the
fix-gh-16314
branch
from
October 11, 2024 19:38
c3f54df to
7cbcf7d
Compare
@kocsismate
kocsismate
force-pushed
the
fix-gh-16314
branch
2 times, most recently
from
October 22, 2024 21:00
de4d9b0 to
1a06371
Compare
...rsistent connection
@kocsismate
kocsismate
force-pushed
the
fix-gh-16314
branch
from
October 30, 2024 10:23
1a06371 to
ec40d2a
Compare
@kocsismate The new test ext/pdo_mysql/tests/gh16314.phpt fails in nightly. May you have a look?
https://github.com/php/php-src/actions/runs/11695572853/job/32571261655
I can fix it right away, so will fix it!
Fixed
Thank you Saki!
Thank you both! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Changes are made on top of #16167 because the two PRs touch the same code. Therefore only the last commit should be reviewed (c3f54df).