-
Notifications
You must be signed in to change notification settings - Fork 7.9k
ext/mysqlnd: Use zval_try_get_string() instead of converting zval #15264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine to me, although I am not sure what difference does it make here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong because the string is never freed it will leak memory for non-interned strings.
Probably should do an in-place "try" convert instead of getting a separate string?
Note that row data is managed by mysqlnd so that will destroy the zval
No description provided.