-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Autotools: Normalize and quote all PHP_NEW_EXTENSION arguments #15144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds Autoconf quote characters to all PHP_NEW_EXTENSION arguments and syncs the CS across the php-src Autotools build system.
@petk
petk
requested review from
nielsdos,
bukka,
Girgias,
devnexen,
TimWolla,
zeriyoshi,
SakiTakamachi,
NattyNarwhal,
alexdowad,
youkidearitai,
dstogov and
derickr
as code owners
July 28, 2024 19:45
@github-actions
github-actions
bot
added
Category: Build System
Extension: openssl
Extension: intl
Extension: bcmath
Extension: bz2
Extension: calendar
Extension: ctype
Extension: date
Extension: dba
Extension: enchant
Extension: exif
Extension: ffi
Extension: filter
Extension: ftp
Extension: gettext
Extension: gmp
Extension: iconv
labels
Jul 28, 2024
@github-actions
github-actions
bot
added
Extension: pdo_firebird
Extension: pdo_mysql
Extension: pdo_odbc
Extension: pdo_pgsql
Extension: pdo_sqlite
Extension: pgsql
Extension: phar
Extension: posix
Extension: reflection
Extension: session
Extension: shmop
Extension: snmp
Extension: sockets
Extension: sodium
Extension: spl
Extension: sqlite3
Extension: standard
Extension: sysvmsg
Extension: sysvsem
Extension: sysvshm
Extension: tidy
Extension: tokenizer
Extension: xsl
Extension: zend_test
Extension: zip
Extension: random
labels
Jul 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack for random
devnexen
devnexen
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Autoconf quote characters to all PHP_NEW_EXTENSION arguments and syncs the CS across the php-src Autotools build system.