-
Notifications
You must be signed in to change notification settings - Fork 8k
Update fuzzer parser dict for property hooks words #14958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fuzzer parser dict for property hooks words #14958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I don't know what this dictionary is needed for, but get and set are not keywords with the hooks rfc.
I don't know what this dictionary is needed for, but get and set are not keywords with the hooks rfc.
A fuzzer can mutate an input corpus randomly, but that's not very efficient to hit new code paths when testing certain features. So fuzzers are often given a dictionary of interesting keywords (well, they don't have to be _key_words, just syntactic elements suffices) that can hit new code paths.
Do we then need to provide a new input corpus with hooks to effectively fuzz hooks?
Thanks @nielsdos for the explanation. Parser fuzzer is used by OSS-fuzz, so it helps to generate more precise code paths for the master branch.
Do we then need to provide a new input corpus with hooks to effectively fuzz hooks?
No, it gets the corpus automatically from the tests located in the Zend/tests directory.
https://github.com/php/php-src/blob/master/sapi/fuzzer/generate_parser_corpus.php
Do we then need to provide a new input corpus with hooks to effectively fuzz hooks?
What jorg says is true, it comes from phpt files. Which is also the reason that we have found variants of issues in the past shortly after the fix for an issue was committed.
Great! Thanks for the explanation
setandgetunsetword