-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Mark multple functions as static #13864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I support this.
@iluuu1994 could you please review the patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you @crrodriguez!
I'm ok with the ext/date change - didn't check the others.
Looks good in general, @crrodriguez could you rebase to fix the conflicts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said, the ext/date ones are fine. The rest looks OK too, but there are now some conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll rebase and merge.
Multiple functions are missing the static qualifier.
struct sigaction act, old_term, old_quit, old_int; all unused.
7c69831 to
3ed2efb
Compare
They are not exported as API, neither for internal usage, only to be used by the current source file.