-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Implement ReflectionConstant #13669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ReflectionConstant #13669
Conversation
Some reflection classes also have a name property, such that dumping it somewhere makes it easy to see what it refers to. Does it make sense to add it here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most Reflection classes implements Reflector and provide a __toString() method. I think that's useful and we could implement that for ReflectionConstant as well (using _const_string()).
717bf13 to
d44ce02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
0f1ec56 to
e99930c
Compare
e99930c to
2b5c527
Compare
2b5c527 to
ec751aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, and maybe renaming const_ to const_ptr? I find the trailing underscore somewhat weird.
Thank you 🙏
Fixes GH-13570