Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ext/curl: Add all missing CURLE constants up to Curl 8.6 #13340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ayesh wants to merge 1 commit into php:master
base: master
Choose a base branch
Loading
from Ayesh:curl-error-consts

Conversation

Copy link
Member

@Ayesh Ayesh commented Feb 6, 2024

ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized.

This commit re-arranges all of the CURLE_* constants to a single part of the curl.stub.php file, and rearranges them to match the order of the error constants in the libcurl documentation1 .

Constants that are deprecated2 are moved shifted to the end of the CURLE_* constants list.

Related: #12000, #13259, #13209, #13282

Footnotes

  1. https://curl.se/libcurl/c/libcurl-errors.html

  2. https://curl.se/libcurl/c/symbols-in-versions.html

jorgsowa reacted with rocket emoji
@Ayesh Ayesh force-pushed the curl-error-consts branch 2 times, most recently from d47b180 to e46d9d4 Compare February 7, 2024 20:47
@Ayesh Ayesh marked this pull request as ready for review February 7, 2024 21:20
@Ayesh Ayesh force-pushed the curl-error-consts branch 3 times, most recently from 1b8cda1 to 30c0c5d Compare March 12, 2024 17:00
@Ayesh Ayesh force-pushed the curl-error-consts branch 3 times, most recently from 568a9d9 to 18754c0 Compare March 19, 2024 17:58
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized.
This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file,
and rearranges them to match the order of the error constants in the libcurl documentation[^1].
Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list.
[^1]: https://curl.se/libcurl/c/libcurl-errors.html
[^2]: https://curl.se/libcurl/c/symbols-in-versions.html
Related: php#12000, php#13259, php#13209, php#13282 
@Ayesh Ayesh force-pushed the curl-error-consts branch from 15d9a53 to ced94e0 Compare May 6, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

@adoy adoy Awaiting requested review from adoy adoy is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /