Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ext/curl: allow changing Caddy port for Server Push tests #13337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dunglas wants to merge 1 commit into php:master
base: master
Choose a base branch
Loading
from dunglas:caddyfile-port

Conversation

Copy link
Member

@dunglas dunglas commented Feb 6, 2024

No description provided.

Copy link
Member

Girgias commented Feb 7, 2024

I don't think this is actually being tested in CI because the Linux image we use doesn't have a recent enough cURL version.

@iluuu1994 @shivammathur do you know if there is a way to run a more recent cURL version?

Copy link
Member

@Girgias Ubuntu 24.04 will be released in a few months. I'd say let's wait for that.

Girgias, dunglas, and shivammathur reacted with thumbs up emoji

Copy link
Member

shivammathur commented Feb 7, 2024
edited
Loading

@Girgias

We can add a workflow job that runs on the Ubuntu 24.04 docker image or we can build curl in CI, but I agree with @iluuu1994 to wait for ubuntu-24.04 runners to be available.

Copy link
Member

Girgias commented Feb 8, 2024

ACK, that makes sense then :)

@dunglas dunglas marked this pull request as ready for review February 11, 2024 10:14
@dunglas dunglas requested a review from adoy as a code owner February 11, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adoy adoy Awaiting requested review from adoy adoy is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /