-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Use AC_CHECK_MEMBERS instead of AC_EGREP_HEADER #13048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AC_EGREP_* macros are not recommended due to their unreliability in certain cases, checking for struct member can be done here using the usual AC_CHECK_MEMBERS instead. AC_CHECK_MEMBERS macro by default defines constant HAVE_STRUCT_SOCKADDR_UN_SUN_LEN.
devnexen
devnexen
approved these changes
Dec 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better indeed
Rechecked and all works correctly. Thanks for the review @devnexen Merged to master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AC_EGREP_* macros are not recommended due to their unreliability in certain cases, checking for struct member can be done here using the usual AC_CHECK_MEMBERS instead.
AC_CHECK_MEMBERS macro by default defines constant HAVE_STRUCT_SOCKADDR_UN_SUN_LEN.