-
Notifications
You must be signed in to change notification settings - Fork 7.9k
php_cli_server: ensure a single Date header is present #12363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch @coppolafab . This mostly looks good, I just have some nits and a remark about the case sensitivity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks almost perfect, just some remark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I'll let the CI finish before merging, and I'll merge tomorrow or so.
EDIT: Windows CI failure is spurious
Merged manually in 8.1 and above, thanks.
Currently the PHP Development Server appends a Date header in the response, despite already set from user code.
Steps to reproduce
index.php:
<?php header('Date: 1985年3月25日 00:20:00 GMT');terminal 1:
$ php -S localhost:8080 index.phpterminal 2:
I have added a check condition before append the header, and a test file.