Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add phpseclib, Psalm, PHPStan nightly tests #12270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danog wants to merge 42 commits into php:master from danog:improve_jit_nightly_tests_3

Conversation

Copy link
Contributor

@danog danog commented Sep 22, 2023

Most of the new nightly tests are failing under JIT, ping @dstogov:

danog added 29 commits September 20, 2023 15:51
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @danog!

export ASAN_OPTIONS=exitcode=139
export PHPSECLIB_ALLOW_JIT=1
php /usr/bin/composer install --no-progress --ignore-platform-reqs
php vendor/bin/paratest --verbose --configuration=tests/phpunit.xml --runner=WrapperRunner || exit $?
Copy link
Member

@iluuu1994 iluuu1994 Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not using paratest for the other frameworks. Can we use it there too? In that case this would be best introduced in a separate PR.

Copy link
Contributor Author

danog commented Oct 10, 2023

Had to reduce the trace count because allocations fails, it turns out JIT was actually disabled after all (??, maybe because my GHA workers have less RAM the the ones used by this org...).

Also submitted #12403 to improve error handling.

@danog danog marked this pull request as ready for review October 10, 2023 15:24
@danog danog requested a review from TimWolla as a code owner October 10, 2023 15:24
Copy link
Contributor Author

danog commented Oct 10, 2023

Had to reduce the trace count because allocations fails, it turns out JIT was actually disabled after all (??, maybe because my GHA workers have less RAM the the ones used by this org...).

Also submitted #12403 to improve error handling.

@danog danog requested a review from iluuu1994 October 10, 2023 15:24
@danog danog changed the title (削除) Add phpseclib, Psalm, PHPStan, UV+AMP nightly tests (削除ここまで) (追記) Add phpseclib, Psalm, PHPStan nightly tests (追記ここまで) Oct 10, 2023
Copy link
Contributor Author

danog commented Oct 10, 2023

Closing this in favor of #12406 against PHP-8.1.

@danog danog closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov dstogov left review comments

@TimWolla TimWolla Awaiting requested review from TimWolla TimWolla is a code owner

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /