-
Notifications
You must be signed in to change notification settings - Fork 8k
number_format: No precesion loss on formatting int's #11584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@marc-mabe
marc-mabe
force-pushed
the
num_format_int
branch
from
July 4, 2023 06:43
59f2068
to
de2038c
Compare
@marc-mabe I merged #11487 so please rebase this. Also please squash it to a single commit when you are in it.
@marc-mabe
marc-mabe
force-pushed
the
num_format_int
branch
from
July 9, 2023 13:26
68bf5d1
to
e81534b
Compare
@marc-mabe
marc-mabe
force-pushed
the
num_format_int
branch
from
July 9, 2023 13:31
e81534b
to
6141ea0
Compare
@bukka done
Internals: https://externals.io/message/120769
bukka
bukka
approved these changes
Jul 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the logic couple of times it looks reasonable to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This is based on #11487 supporting negative decimal places on
number_format
.number_format
will perform formatting the int (zend_long
) value without casting it to float (double
)zend_ulong
to be able to round high numbers without integer overflow (e.g.9223372036854775806
->10,000,000,000,000,000,000
)zend_long
for decimals (dec
argument) as there is a possible integer overflow with big numbers. This issue still exists on formatting floats but fixing it would be a BC break. (opened a separate PR number_format: prevent integer overflow on big decimal number #11649 )PS: I'm not a C developer and this is the first time for me handling pointers and malloc ... please review carefully that I haven't done a mistake ending up in crashes :)