Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

include cleanup part 5 #10345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxKellermann wants to merge 105 commits into php:master from CM4all:include_cleanup5
Closed

include cleanup part 5 #10345

MaxKellermann wants to merge 105 commits into php:master from CM4all:include_cleanup5

Conversation

Copy link
Contributor

@MaxKellermann MaxKellermann commented Jan 16, 2023 •
edited
Loading

This is a "revert of revert" of my include cleanup PRs: #10216 #10220 #10279 #10300 ... plus a few more commits (including the DTrace fix #10334)

My previous work was reverted after @dstogov demanded it: #10220 (comment)

Meanwhile, I have posted a suggestion to update PHP's coding standard in favor of my cleanups:

Until it is decided whether to accept my coding standard suggestion, I'll keep this PR up to date for you to review.

mlocati, KoenvanMeijeren, tadhgboyle, and kitrio reacted with thumbs up emoji emmanuelballery reacted with laugh emoji 
This eliminates the need to include zend_portability.h.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smalyshev smalyshev smalyshev left review comments

@devnexen devnexen devnexen left review comments

@dstogov dstogov dstogov requested changes

@arnaud-lb arnaud-lb Awaiting requested review from arnaud-lb arnaud-lb will be requested when the pull request is marked ready for review arnaud-lb is a code owner

@bukka bukka Awaiting requested review from bukka bukka will be requested when the pull request is marked ready for review bukka is a code owner

@Girgias Girgias Awaiting requested review from Girgias Girgias will be requested when the pull request is marked ready for review Girgias is a code owner

@nielsdos nielsdos Awaiting requested review from nielsdos nielsdos will be requested when the pull request is marked ready for review nielsdos is a code owner

@TimWolla TimWolla Awaiting requested review from TimWolla TimWolla will be requested when the pull request is marked ready for review TimWolla is a code owner

@zeriyoshi zeriyoshi Awaiting requested review from zeriyoshi zeriyoshi will be requested when the pull request is marked ready for review zeriyoshi is a code owner

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi will be requested when the pull request is marked ready for review SakiTakamachi is a code owner

@kamil-tekiela kamil-tekiela Awaiting requested review from kamil-tekiela kamil-tekiela will be requested when the pull request is marked ready for review kamil-tekiela is a code owner

@alexdowad alexdowad Awaiting requested review from alexdowad alexdowad will be requested when the pull request is marked ready for review alexdowad is a code owner

@youkidearitai youkidearitai Awaiting requested review from youkidearitai youkidearitai will be requested when the pull request is marked ready for review youkidearitai is a code owner

@adoy adoy Awaiting requested review from adoy adoy will be requested when the pull request is marked ready for review adoy is a code owner

+1 more reviewer

@nbish11 nbish11 nbish11 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /