-
Notifications
You must be signed in to change notification settings - Fork 23
ErrorFormatter: support PHP Console Highlighter 1.0.0 #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3959ec5 to
7bef99d
Compare
PHP Console Highlighter 1.0.0 has just been released. This PR adds cross-version support for both PHP Console Highlighter < 1.0.0 and 1.0.0+ to PHP Parallel Lint, which allows people to update the Highlighter dependency to the latest version. Includes changelog entry to allow this PR to be included in the 1.3.2 release. Ref: https://github.com/php-parallel-lint/PHP-Console-Highlighter/releases/tag/v1.0.0
7bef99d to
d5b30a7
Compare
@grogy Would be great if this PR could be merged so 1.3.2 can be released. 🙏🏻 Thanks!
Thank you, it looks good :-)
Thanks @grogy. You okay with me tagging 1.3.2 now ?
Yes, I agree. You will create "intro" message for new version? When yes, than I suggest
New version support PHP 8.1, is again tested against PHP 5.3 and we welcome @jrfnl as maintainer.
What do you mean by intro message ? And how do you normally do this ?
I thought it was a case of tagging the last commit, pushing the tag to GH, then the release workflow will create the Draft release and I add the changelog to it from the other PR ?
I mean one sentence before contain from changelog.
Example:
New version support PHP 8.1, is again tested against PHP 5.3 and we welcome @jrfnl as maintainer.
### Added
- Support for PHP Console Highlighter 1.0.0, which comes with PHP Console Color 1.0.1, [#92] from [@jrfnl].
### Fixed
- Bug fix: make Phar file run independently of project under scan [#63] from [@jrfnl], fixes [#61].
- Bug fix: checkstyle report could contain invalid XML due to insufficient output escaping [#73] from [@gmazzap], fixes [#72].
- Fix Phar building [#70] from [@jrfnl]. This fixes PHP 8.1 compatibility for the Phar file.
- Documentation fix: the `--show-deprecated` option was missing in both the README as well as the CLI `help` [#84] from [@jrfnl], fixes [#81] reported by [@stronk7].
### Changed
- README: updated information about PHAR availability [#77] from [@jrfnl].
.......
Ah, in the release notes ? Or do you use annotated tags ?
I've used an annotated tag now. Fingers crossed I've done it correctly.
Perfect 🚀
PHP Console Highlighter 1.0.0 has just been released.
This PR adds cross-version support for both PHP Console Highlighter < 1.0.0 and 1.0.0+ to PHP Parallel Lint, which allows people to update the Highlighter dependency to the latest version.
Includes changelog entry to allow this PR to still be included in the 1.3.2 release.
Ref: https://github.com/php-parallel-lint/PHP-Console-Highlighter/releases/tag/v1.0.0