Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix vendor location #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grogy merged 1 commit into php-parallel-lint:master from erkens:Erkens-patch-1
Mar 19, 2020
Merged

Conversation

Copy link

@erkens erkens commented Feb 21, 2020

Fixing issue with autoloader when executing from outside the source directory: #1

e1himself reacted with thumbs up emoji
Fixing issue with autoloader when executing from outside the source directory:
php-parallel-lint#1 
Copy link

@grogy Any chances this fix will be merged soon? Our CI checks have started to fail recently. Not sure what changed, but it cannot find autoload.php anymore. 🤷‍♂️

This change fixes it.

grogy reacted with thumbs up emoji

@grogy grogy merged commit fd079b9 into php-parallel-lint:master Mar 19, 2020
Copy link
Member

grogy commented Mar 19, 2020

Thank you. This section can be replaced with using PSR-4 and autoloading in composer. I do it later or anyone can send PR :-)

Copy link
Collaborator

jrfnl commented Mar 19, 2020

@grogy I would, but there's still a few too many open PRs waiting....

Copy link
Member

grogy commented Mar 19, 2020

You have right. I will resolve it during next 7 days

Copy link
Collaborator

jrfnl commented Mar 19, 2020

@grogy Happy to hear that and I look forward to the next release.

Copy link

e1himself commented Mar 20, 2020
edited
Loading

@grogy

This section can be replaced with using PSR-4 and autoloading in composer.

I'm afraid this is not precisely correct. As this section is solving a different problem. Changing classmap autoloading to PSR-4 will not change anything in regards to this exact problem.

Copy link
Member

grogy commented Mar 25, 2020

I tried the same situation. Do you have right @e1himself PSR-4 does not solve this case.

Example for sumulation:

# show folder structure
$ ls /app
composer.json vendor ...
# clone this tool 
$ git clone git@github.com:php-parallel-lint/PHP-Parallel-Lint.git /app/folder1/folder2/folder3/folder4/folder5/php-parallel-lint
# run with error
$ cd /
$ php /app/folder1/folder2/folder3/folder4/folder5/php-parallel-lint/parallel-lint
You must set up the project dependencies, run the following commands:
curl -s http://getcomposer.org/installer | php
php composer.phar install

Solution is run create-project like and 1 small fix in code.

composer create-project php-parallel-lint/php-parallel-lint:dev-master /app/folder-v2-1/folder2/folder3/folder4/folder5/php-parallel-lint

Please try it in your project. ...:dev-master is temporary, when it will be ok then we can create new release :-)

Copy link
Collaborator

jrfnl commented Mar 25, 2020

@grogy I suppose PR #9, which I opened upstream in Aug last year and here a month ago, can be closed then .... ?

Copy link
Member

grogy commented Mar 25, 2020

@jrfnl ou :( it's the same solution. Credit for a change belong to you

Copy link
Collaborator

jrfnl commented Mar 25, 2020
edited
Loading

@grogy No worries. Just glad it's fixed in the repo now. Might have saved you some time though if you'd looked at the open PRs first.

grogy reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /