-
Notifications
You must be signed in to change notification settings - Fork 23
CS/QA: Tests: add PSR-4 compliant namespace declarations #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, forgot I could only pull this after #103 has been merged. Will rebase after that PR has gone in.
@jrfnl you can rebase :)
@jrfnl
jrfnl
force-pushed
the
feature/qa-add-namespaces-to-tests
branch
from
March 3, 2022 16:07
725f88e to
f9d6d90
Compare
@grogy Done! Build running now. I expect it to pass.
Great, it makes sense. When pass tests than I merged it :)
grogy
grogy
approved these changes
Mar 3, 2022
Includes: * Renaming the files to reflect the name of the class therein and to use the `php` instead of `phpt` file extension. * Updating the `autoload-dev` directive in the `composer.json` file. * Updating the exclusions in the PHPCS config. Note: using PSR-4 compliant `*Test,php` filenames will (temporarily) silently break the running of the tests for PHP 5.3-5.5 as Nette Tester 1.x can't find the tests anymore. We can ignore this for now as this will be fixed in one of the next PRs where the tests will switch over to the PHPUnit testing framework.
@jrfnl
jrfnl
force-pushed
the
feature/qa-add-namespaces-to-tests
branch
from
March 3, 2022 22:12
f9d6d90 to
d589157
Compare
Hmm... not sure why the build didn't run/update statuses, but I've retriggered it now and looks like it's running.
Thank you. GitHub actions were freezen :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
phpinstead ofphptfile extension.autoload-devdirective in thecomposer.jsonfile.Note: using PSR-4 compliant
*Test,phpfilenames will (temporarily) silently break the running of the tests for PHP 5.3-5.5 as Nette Tester 1.x can't find the tests anymore.We can ignore this for now as this will be fixed in one of the next PRs where the tests will switch over to the PHPUnit testing framework.