-
Notifications
You must be signed in to change notification settings - Fork 158
Comments
Open
Conversation
Contributor
jamiehannaford
commented
Jun 13, 2016
Collaborator
Author
haphan
commented
Jun 17, 2016
@jamiehannaford these values are retrievable via /v2.0/networks, why not also map them to Network model?
Besides, what is the general strategy for sdk to cover extensions?
Contributor
jamiehannaford
commented
Jun 17, 2016
@haphan All extensions code should live under the extensions dir for that service, for example here. I wanted to do this so that we don't make any assumptions about users using a specific extension and mixing that code with the core service.
Even if the extension modifies a core URL endpoint (e.g. /networks) I still think we should separate but could have the extension resource class (ExtNetwork) extend the core resource (Network). We could even use the core Api and Params classes if the operations are identical, but at least we'd have separation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jamiehannaford