Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

[rfr] Map network fields#61

Open
haphan wants to merge 1 commit intophp-opencloud:master from
haphan:network-type
Open

[rfr] Map network fields #61
haphan wants to merge 1 commit intophp-opencloud:master from
haphan:network-type

Conversation

@haphan
Copy link
Collaborator

@haphan haphan commented Jun 9, 2016

Copy link
Contributor

Aren't these values provided by the layer-3 and provider extensions?

Copy link
Collaborator Author

haphan commented Jun 17, 2016

@jamiehannaford these values are retrievable via /v2.0/networks, why not also map them to Network model?

Besides, what is the general strategy for sdk to cover extensions?

Copy link
Contributor

@haphan All extensions code should live under the extensions dir for that service, for example here. I wanted to do this so that we don't make any assumptions about users using a specific extension and mixing that code with the core service.

Even if the extension modifies a core URL endpoint (e.g. /networks) I still think we should separate but could have the extension resource class (ExtNetwork) extend the core resource (Network). We could even use the core Api and Params classes if the operations are identical, but at least we'd have separation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /