Comments

Add Sahara data processing support#157

Open

ekasitk wants to merge 6 commits intophp-opencloud:master from

ekasitk:sahara

Open

Add Sahara data processing support #157
ekasitk wants to merge 6 commits intophp-opencloud:master from
ekasitk:sahara

Conversation

@ekasitk

Copy link

Contributor

@ekasitk ekasitk commented Sep 30, 2017

This PR provides the first version of sahara data processing support (ref. https://developer.openstack.org/api-ref/data-processing/).

@haphan

Copy link

Collaborator

haphan commented Feb 6, 2018

@ekasitk Is this PR ready for review? Thanks

@haphan haphan closed this

Feb 6, 2018

@haphan haphan reopened this

Feb 6, 2018

@ekasitk

Copy link

Contributor Author

ekasitk commented Feb 6, 2018

@haphan Yes, it is ready for review.

@haphan

Copy link

Collaborator

haphan commented Feb 6, 2018 •

edited

Loading

Can you rebase with master and push again? It would also fix travis build @ekasitk

ekasitk and others added 6 commits

February 15, 2018 09:35

@ekasitk


 Add support for Sahara data processing

b86acf2

@ekasitk


 Add sahara job interface

610bae9

@ekasitk


 Add sahara createMultipleClusters

bd2a9a5

@ekasitk


 Add create_multiple_clusters.php

77c025c

@ekasitk


 Do PSR2 formatting

3733cca

@ekasitk


 Make username and password as an option in post job binary

77ac624

@ekasitk ekasitk force-pushed the sahara branch from 15b8191 to 77ac624 Compare

February 15, 2018 03:07

@ekasitk

Copy link

Contributor Author

ekasitk commented Feb 15, 2018

@haphan Rebase was done. Could you review it again?

haphan

haphan requested changes

Feb 15, 2018

View reviewed changes

Copy link

Collaborator

@haphan haphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ekasitk, very high quality PR. Just a few comments below; mainly to follow existing standard and convention of other services in this SDK

Add description and return types where possible (src/DataProcessing/v1/Service.php). This will help to generate very nice reference doc.
Add unit tests
Nice to have: integration tests.

samples/data_processing/cluster/create_cluster.php

'neutronManagementNetwork' => '{neutronManagementNetworkId}',

];

$cluster = $sahara->createCluster($options);

Copy link

Collaborator

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add type hint to $cluster
e.g. /**@var OpenStack\DataProcessing\v1\Models\Cluster $cluster */

samples/data_processing/cluster/create_multiple_clusters.php

$clusters = $sahara->createCluster($options);

foreach ($clusters as $cluster) {

print_r($cluster);

Copy link

Collaborator

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add type hint

samples/data_processing/cluster/get_cluster.php

$sahara = $openstack->dataProcessingV1(['region' => '{region}']);

$cluster = $sahara->getCluster(['id' => '{clusterId}']);

Copy link

Collaborator

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add type hint

samples/data_processing/cluster/delete_cluster.php

$sahara = $openstack->dataProcessingV1(['region' => '{region}']);

$cluster = $sahara->getCluster(['id' => '{clusterId}']);

Copy link

Collaborator

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add type hint

samples/data_processing/cluster/list_clusters.php

];

$clusters = $sahara->listClusters($options);

foreach ($clusters as $cluster) {

Copy link

Collaborator

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add type hint to $client

samples/data_processing/cluster/update_cluster.php

$sahara = $openstack->dataProcessingV1(['region' => '{region}']);

$cluster = $sahara->getCluster(['id' => '{clusterId}']);

Copy link

Collaborator

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add type hint

samples/data_processing/cluster_template/create_cluster_template.php

'name' => '{ClusterTemplateName}',

];

$clusterTemplate = $sahara->createClusterTemplate($options);

Copy link

Collaborator

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add type hint

src/DataProcessing/v1/Models/Image.php

protected $resourcesKey = 'images';

protected $aliases = [

'OS-EXT-IMG-SIZE:size' => 'OSEXTIMGSIZEsize',

Copy link

Collaborator

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify to size?

Labels

None yet

2 participants

@ekasitk @haphan

Comments

Conversation

@ekasitk ekasitk commented Sep 30, 2017

Uh oh!

haphan commented Feb 6, 2018

Uh oh!

ekasitk commented Feb 6, 2018

Uh oh!

haphan commented Feb 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ekasitk commented Feb 15, 2018

Uh oh!

@haphan haphan left a comment

Choose a reason for hiding this comment

Uh oh!

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

Uh oh!

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

Uh oh!

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

Uh oh!

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

Uh oh!

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

Uh oh!

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

Uh oh!

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

Uh oh!

@haphan haphan Feb 15, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

haphan commented Feb 6, 2018 •

edited

Loading