Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fixes PHPUnit 8.4 compatibility #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalbundyra merged 1 commit into php-mock:master from MasterOdin:phpunit84
Oct 5, 2019
Merged

Fixes PHPUnit 8.4 compatibility #40

michalbundyra merged 1 commit into php-mock:master from MasterOdin:phpunit84
Oct 5, 2019

Conversation

Copy link
Contributor

@MasterOdin MasterOdin commented Oct 5, 2019

Closes #39

Fixes things to run under PHPUnit 8.4 with all tests passing with the exception of a warning on phpmock\phpunit\PHPMockTest::testBackupStaticAttributes due to sebastianbergmann/phpunit#3879.

I've extended Travis-CI to test against PHPUnit 8.3 and 8.4 as well.

Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MasterOdin this looks awesome. 👍 Thanks a lot for your effort!
I am going to release it soon.

@michalbundyra michalbundyra added this to the 2.5.0 milestone Oct 5, 2019
michalbundyra added a commit that referenced this pull request Oct 5, 2019
@michalbundyra michalbundyra merged commit 07a05d4 into php-mock:master Oct 5, 2019
Copy link
Member

Thanks, @MasterOdin!

Copy link
Contributor Author

No problem, this is a really indispensable piece of kit for unit testing without having to build endless abstractions!
michalbundyra reacted with thumbs up emoji

Copy link
Contributor Author

As a follow-up, with the release of PHPUnit 8.4.1 today, all unit tests pass without issue.
michalbundyra reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalbundyra michalbundyra michalbundyra approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

Incompatibility with PHPUnit 8.4

AltStyle によって変換されたページ (->オリジナル) /