Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added PHPUnit 8 support #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalbundyra merged 4 commits into php-mock:master from michalbundyra:feature/phpunit-8
Mar 5, 2019

Conversation

Copy link
Member

@michalbundyra michalbundyra commented Feb 2, 2019

No description provided.

OndraM and BafS reacted with thumbs up emoji
Copy link

OndraM commented Feb 7, 2019

I guess :void must be added as return type to tearDown() etc. methods. This is backward compatible change (won't break support for PHPUnit 7 etc.), so it could be IMHO safely done.

Copy link
Member Author

@OndraM Yes, but the changes we need to do in https://github.com/php-mock/php-mock, and there we still support PHP 5.6. I can prepare compatibility level to support both versions, but not sure if it is worth to do that.

Copy link

OndraM commented Feb 7, 2019
edited
Loading

Well I don't think its worth the effort: you can just drop the support of old PHP - who uses it can still use the old version of this library, it won't stop working for him. But anyone with PHPUnit 6+ must already use PHP 7+ (see https://phpunit.de/supported-versions.html ).

asgrim reacted with thumbs up emoji

Copy link

I agree with @OndraM . I think would be better release major version with dropped php5. In readme should point which version should use.

PS
In any case i created fork for my self :D

Copy link
Member Author

I've decided to add PHPUnit 8 support without new major release.
I can't see the point of creating new major release without any additional features/changes, as adding the support of v8 was quite easy.

@KartaviK @OndraM Please have a look on PR: php-mock/php-mock#22 if you have a sec. Thanks!

@michalbundyra michalbundyra merged commit a25b10b into php-mock:master Mar 5, 2019
michalbundyra added a commit that referenced this pull request Mar 5, 2019
@michalbundyra michalbundyra deleted the feature/phpunit-8 branch June 7, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /