-
-
Notifications
You must be signed in to change notification settings - Fork 20
Added PHPUnit 8 support #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PHPUnit 8 support #31
Conversation
OndraM
commented
Feb 7, 2019
I guess :void
must be added as return type to tearDown() etc. methods. This is backward compatible change (won't break support for PHPUnit 7 etc.), so it could be IMHO safely done.
@OndraM Yes, but the changes we need to do in https://github.com/php-mock/php-mock, and there we still support PHP 5.6. I can prepare compatibility level to support both versions, but not sure if it is worth to do that.
Well I don't think its worth the effort: you can just drop the support of old PHP - who uses it can still use the old version of this library, it won't stop working for him. But anyone with PHPUnit 6+ must already use PHP 7+ (see https://phpunit.de/supported-versions.html ).
KartaviK
commented
Feb 18, 2019
I agree with @OndraM . I think would be better release major version with dropped php5. In readme should point which version should use.
PS
In any case i created fork for my self :D
I've decided to add PHPUnit 8 support without new major release.
I can't see the point of creating new major release without any additional features/changes, as adding the support of v8 was quite easy.
@KartaviK @OndraM Please have a look on PR: php-mock/php-mock#22 if you have a sec. Thanks!
InvocationMocker is marked as final and cannot be mocked anymore.
No description provided.