-
-
Notifications
You must be signed in to change notification settings - Fork 53
Open
Conversation
mnapoli
commented
May 5, 2022
Member
Duplicates #35?
Author
Quite close indeed. I'd just not add generics to the keys. Despite #35 being closed, I still think this would be a good idea. Locators scoped to some interface are quite common. It'd be great to hint autocompletion about them:
ContainerInterface<Foo> $container->get('bar')->... and be suggested with what Foo provides.
The fact that psalm/phpstan would complain about this shouldn't be a blocker to me. Eg they could stop complaining when the template type is of mixed.
ro0NL
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
May 7, 2022
...face (nicolas-grekas) This PR was merged into the 6.1 branch. Discussion ---------- [Contracts/Service] Add generics to ServiceProviderInterface | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Should allow using `ServiceProviderInterface<MyInterface>` and have autocompletion when doing `$provider->get->...`. Submitted upstream as php-fig/container#44 Commits ------- 2aa459a [Contracts/Service] Add generics to ServiceProviderInterface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WDYT?