Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add header support for Symfony's produce command #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Copy link
Contributor

@TiMESPLiNTER TiMESPLiNTER commented Oct 10, 2019
edited
Loading

Fixes #963

Copy link
Contributor

@TiMESPLiNTER You can check local test run script instructions here https://github.com/php-enqueue/enqueue-dev/blob/master/docs/contribution.md (kinda obscure, that's why I'm linking it in case you've missed it)

TiMESPLiNTER reacted with thumbs up emoji

Copy link
Contributor

Looks good to me. I've double checked that SimpleClient does indeed automatically convert string messages into Message instance.

Copy link
Contributor

Steveb-p commented Nov 9, 2019

@makasim Looks simple enough to me. Could I merge PR's like this in the future in case you're occupied or you'd like to keep control over it?

Copy link
Member

makasim commented Nov 9, 2019

@Steveb-p sure, I don't mind

@Steveb-p Steveb-p merged commit 3374d2f into php-enqueue:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add options to send headers with enqueue:produce command

AltStyle によって変換されたページ (->オリジナル) /