Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Make serializer configurable via YAML configuration #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lenchester wants to merge 3 commits into php-enqueue:master
base: master
Choose a base branch
Loading
from lenchester:feature/serializer-replaceable

Conversation

Copy link

@lenchester lenchester commented May 20, 2025
edited
Loading

This change enables users to specify custom serializers with configuration
options in their Enqueue bundle YAML configuration, improving flexibility
when working with different message formats.

  • Add support for configuring serializers through YAML in RdKafkaContext
  • Allow serializer specification as a class name, array with options, or instance

- Add support for configuring serializers through YAML in RdKafkaContext
- Allow serializer specification as a class name, array with options, or instance
- Ensures robustness by providing a default serializer
- Refactoring
Copy link
Author

@Steveb-p can you review the PR?

Copy link
Author

Hmm, I’m not sure whether the error was caused by my changes.

Copy link
Contributor

Hmm, I’m not sure whether the error was caused by my changes.

Seems like it was a one-off failure in one job in tests.

lenchester reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /