-
Notifications
You must be signed in to change notification settings - Fork 441
feat(GPS): allow send attributes in Google PubSub message. #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
p-pichet
wants to merge
1
commit into
php-enqueue:master
from
ubitransports:master-gps-attributes-with-ci
Closed
feat(GPS): allow send attributes in Google PubSub message. #1352
p-pichet
wants to merge
1
commit into
php-enqueue:master
from
ubitransports:master-gps-attributes-with-ci
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@makasim this one should be good.
One of the tests requires an update, since you're changing behavior slightly.
All others are deprecations and warnings (these are awful, but it is how it is).
There was 1 failure: 1) Enqueue\Gps\Tests\GpsProducerTest::testShouldSendMessage Expectation failed for method name is "publish" when invoked 1 time(s) Parameter 0 for invocation Google\Cloud\PubSub\Topic::publish(Array (...), Array ()) does not match expected value. Failed asserting that two arrays are identical. --- Expected +++ Actual @@ @@ Array &0 ( 'data' => '{"body":"","properties":[],"headers":[]}' + 'attributes' => Array &1 () ) /home/runner/work/enqueue-dev/enqueue-dev/pkg/gps/GpsProducer.php:42 /home/runner/work/enqueue-dev/enqueue-dev/pkg/gps/Tests/GpsProducerTest.php:55 phpvfscomposer:///home/runner/work/enqueue-dev/enqueue-dev/vendor/phpunit/phpunit/phpunit:60 --
thanks @Steveb-p
The first PR decide to run the CI, i see to close this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.