Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fixed symfony 6.1 deprecation notices #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zyv4yk wants to merge 6 commits into php-enqueue:master from zyv4yk:fix/deprecation

Conversation

Copy link

@zyv4yk zyv4yk commented Jun 5, 2024

fixes #1270

1x: Method "Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()" might add "void" as a native return type declaration in the future. Do the same in implementation "Enqueue\Doctrine\DoctrineSchemaCompilerPass" now to avoid errors or add an explicit @return annotation to suppress this message.
 1x: The "Symfony\Component\Console\Command\Command::$defaultName" property is considered final. You should not override it in "Enqueue\Symfony\Consumption\ConfigurableConsumeCommand".
 1x: The "Symfony\Component\Console\Command\Command::$defaultName" property is considered final. You should not override it in "Enqueue\Symfony\Client\ConsumeCommand".
 1x: The "Symfony\Component\Console\Command\Command::$defaultName" property is considered final. You should not override it in "Enqueue\Symfony\Client\ProduceCommand".
 1x: The "Symfony\Component\Console\Command\Command::$defaultName" property is considered final. You should not override it in "Enqueue\Symfony\Client\SetupBrokerCommand".
 1x: The "Symfony\Component\Console\Command\Command::$defaultName" property is considered final. You should not override it in "Enqueue\Symfony\Client\RoutesCommand".

mundiir reacted with thumbs up emoji
@zyv4yk zyv4yk marked this pull request as ready for review June 5, 2024 08:37
Copy link
Author

zyv4yk commented Jun 11, 2024

Hi @makasim, can you run CI actions, please?

makasim reacted with thumbs up emoji

Copy link
Author

zyv4yk commented Jun 11, 2024
edited
Loading

I've fixed mostly all the tests, but there is still some errors present. I will be happy for someone to help.

GuzzleHttp\Exception\ClientException: Client error: `POST http://localstack:4576` resulted in a `404 Not Found` response:
The requested resource could not be found.

@zyv4yk zyv4yk marked this pull request as draft August 1, 2024 08:22
@zyv4yk zyv4yk marked this pull request as ready for review August 1, 2024 08:24
@zyv4yk zyv4yk marked this pull request as draft August 1, 2024 08:37
@zyv4yk zyv4yk marked this pull request as ready for review August 2, 2024 08:32
Copy link
Member

makasim commented Nov 18, 2024

zyv4yk reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symfony 6.1 deprecations
2 participants

AltStyle によって変換されたページ (->オリジナル) /