-
Notifications
You must be signed in to change notification settings - Fork 442
Bugfix in RdKafkaProducer:flush()
method
#1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Avoid TypeError in `RdKafkaProducer::flush()`
It seems there is an issue with localstack deployment, because after the services are up, one of them (the one on port 4576) shuts down. All of the http requests to service healtcheck curl -i http://localhost:4576/_localstack/health
will return 404 🤷
What I've tried is to change the localstack image version, by downgrading and upgrading the patch, minor and major versions, but still no luck in having it working.
I notice that this issue happens in other PRs as well.
@makasim @Steveb-p please help with this issue.
@makasim ok, please let me know - since this is a failing component of testing stage (not related to the code quality/functionality itself) - who could help me with this issue? I mean, who is maintaining the functional tests environment, so we can check together?
Contributors, like you.
1ed114e
to
a52cd38
Compare
@makasim please run the workflow. I've brought some changes.
alexbusu
commented
Jun 18, 2024
@makasim please run the workflow again.
alexbusu
commented
Jun 19, 2024
@makasim please run the workflow.
alexbusu
commented
Jun 19, 2024
Now the only failing test is Enqueue\SnsQs\Tests\Spec\SnsQsSendToTopicAndReceiveNoWaitFromQueueTest::test()
:
Failed asserting that null is an instance of interface "Interop\Queue\Message".
@makasim @Steveb-p it's not clear to me why this fails here; it is not failing when I run for the same environment on my local machine. What would you suggest, what should I try?
a6fb467
to
aa29e73
Compare
9d9a04f
to
12d3738
Compare
Avoid TypeError in
RdKafkaProducer::flush()