Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bugfix in RdKafkaProducer:flush() method #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexbusu-motork wants to merge 12 commits into php-enqueue:master
base: master
Choose a base branch
Loading
from alexbusu-motork:patch-1

Conversation

Copy link

@alexbusu-motork alexbusu-motork commented Apr 3, 2024

Avoid TypeError in RdKafkaProducer::flush()

Avoid TypeError in `RdKafkaProducer::flush()`
Copy link
Author

It seems there is an issue with localstack deployment, because after the services are up, one of them (the one on port 4576) shuts down. All of the http requests to service healtcheck curl -i http://localhost:4576/_localstack/health will return 404 🤷
What I've tried is to change the localstack image version, by downgrading and upgrading the patch, minor and major versions, but still no luck in having it working.
I notice that this issue happens in other PRs as well.
@makasim @Steveb-p please help with this issue.

Copy link
Member

makasim commented Apr 8, 2024
edited
Loading

@makasim @Steveb-p please help with this issue.

I can review PR and merge green one. Release a new version. That's it. So, don't expect me to fix failing CI.

Copy link
Author

@makasim ok, please let me know - since this is a failing component of testing stage (not related to the code quality/functionality itself) - who could help me with this issue? I mean, who is maintaining the functional tests environment, so we can check together?

Copy link
Member

makasim commented Apr 8, 2024

Contributors, like you.

Copy link
Author

@makasim please run the workflow. I've brought some changes.

makasim reacted with thumbs up emoji

Copy link

@makasim please run the workflow again.

Copy link

@makasim please run the workflow.

Copy link

Now the only failing test is Enqueue\SnsQs\Tests\Spec\SnsQsSendToTopicAndReceiveNoWaitFromQueueTest::test():

Failed asserting that null is an instance of interface "Interop\Queue\Message".

https://github.com/php-enqueue/enqueue-dev/actions/runs/9580921964/job/26416695363?pr=1347#step:10:266

@makasim @Steveb-p it's not clear to me why this fails here; it is not failing when I run for the same environment on my local machine. What would you suggest, what should I try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /