-
Notifications
You must be signed in to change notification settings - Fork 442
Update uuid DbalProducer.php #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KrisHarris
wants to merge
1
commit into
php-enqueue:master
from
RivieraTravel:ramsey4_1-breakingInterfaceChange
Open
Update uuid DbalProducer.php #1346
KrisHarris
wants to merge
1
commit into
php-enqueue:master
from
RivieraTravel:ramsey4_1-breakingInterfaceChange
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from this thread ramsey/uuid#327 ramsey/uuid 4.1 introduced LazyUuidFromString object which is used over the original Uuid object this causes conversions issues when using the objects, but can simply use toString() from UuidInterface to convert to actual guid when inserting
svI24
commented
Oct 25, 2024
I have the same issue with the Uuid and can confirm that the change works.
When can we expect that this will be merged into master branch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this thread ramsey/uuid#327 ramsey/uuid 4.1 introduced Ramsey\Uuid\Lazy\LazyUuidFromString object which is used over the original Ramsey\Uuid\Uuid object when generating Uuids (I.E. when using Uuid::uuid4()).
This causes conversion issues when using the objects on inserting records.
But can simply use toString() from UuidInterface to convert to actual guid (string) when calling DBAL insert.
The change means that
'id' => DbalType::GUIDon parameter types array is correct, rather than throwing:This change is BC, tested with ramsey/uuid:3.9.7 and ramsey/uuid:4.7.5