Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Run CI tests in php 8.3 in CI #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amenophis wants to merge 6 commits into php-enqueue:master
base: master
Choose a base branch
Loading
from amenophis:php83
Open

Conversation

Copy link

@amenophis amenophis commented Mar 22, 2024

Hi,
This PR allows to run the CI on php 8.3

Copy link
Author

@makasim Could you please authorize the workflow run to see the state of tests 🙏

makasim reacted with thumbs up emoji

Copy link
Author

@makasim Thanks for merging the other PR, could you restart the CI please ?

Copy link
Author

Hi @makasim
It seems the php 8.3 images added by makasim/docker-nginx-php-fpm#9 are not available on the docker registry.
Did you build and push them ?

Thanks 🙏

Copy link
Member

makasim commented Apr 5, 2024
edited
Loading

Nope, but I'll try on weekends. (feel free to ping me the next week).

Copy link
Author

Hi @makasim
Since the image for php 8.3 was just built, could you restart the CI on this branch ?

Thanks 🙏

makasim reacted with thumbs up emoji

Copy link
Member

makasim commented Apr 8, 2024

btw, you can drop too old versions if they fail ( do not spent time fixing them).

Copy link
Member

makasim commented Apr 8, 2024

symfony 5.46円.3 and php 8.4 would be enough

Copy link
Author

@makasim I did some fixes in the CI, and restrict version to PHP 8.2/8.3 and Symfony 5.5/6.4 for now.

Can you restart the CI please ?
🙏

makasim reacted with thumbs up emoji

Copy link
Author

Hi @makasim
It seems that failed tests are flaky, so could you please retry them ?

Is it normal that it donesn't automatically start on new commit ?

Thanks 🙏

Copy link
Author

Hi @makasim
Could you retry last CI run ?

Thanks 🙏

makasim reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /