-
Notifications
You must be signed in to change notification settings - Fork 440
base64 encode SNS Header message attribure #1308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base64 encode SNS Header message attribure #1308
Conversation
This solution would not work in cases where there are multiple distinct services using enqueue for cross-service communication via messages because this change would introduce bease64 encoding of messages, but if there are other services using an older version of this library, that can not base64 decode messages, the message consumption would break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can leave this without encoding base64 for now (keep changes not breaking).
In the next major release, we can add base64_encode part. 🤔
Fixes #1307