-
Notifications
You must be signed in to change notification settings - Fork 440
Add support for Symfony 6; drop < 5.1 #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❤️ the commit history 😅
Currently investigating the issue with async event listeners being registered twice — either an issue with the fixture app, or Sf 6 🤔
d865b20
to
2277674
Compare
@makasim take a look pls.
Squashed everything to avoid letting all this commit message nonsense into master ;)
2277674
to
e10a894
Compare
Screenshot 2022年02月15日 at 22 02 27
Screenshot 2022年02月15日 at 22 02 37
Posting the commit message history for posterity :D
I see some juggling with event dispatcher.
Could dropping Symfony 4 support simplify things ?
If so, let's do it.
@andrewmy thank you for the great work!
The new dispatcher thing was introduced in 5.1, so dropping means a bit wider scope. I'm not against it, your call :)
Let's keep it simple. Could you set "symfony/xxx": "^5.1|^6"
If it means a new major release, then we could include #1230 in it.
@Steveb-p bumping minimum deps can happen in a patch version as long as the external API is unchanged.
In this case there is a slight difference in configuration — tricky case.
Used this opportunity to burn down whatever I found regarding the < 5 BC layer.
There's still the thing about one different line in fixture apps — session. Looks ugly but not warranting instant drop of anything < 5.4 I guess.
If it means a new major release,
Nah, it's a hell of a lot of work. just an ordinary release.
LGTM, could be merged?
Yes please, with a pretty tag on top 🙏
Could we have a release? :)
Uh oh!
There was an error while loading. Please reload this page.