Approved CI run.

Thanks @makasim

It seems CI errors are identical to the master branch and it's not related to my PR.

Master has to be fixed before I can merge this PR. I understand that it has nothing to do with your changes but master has to be green, otherwise it all become mess pretty soon.

No problem. I understand that 👍🏼

Thanks for your feedback

Ping

This PR also fixes #1234 (#1236 duplicates this one, I'll close it).

CI fails. Should be green before I can merge.

CI fails. Should be green before I can merge.

@makasim Does someone work on this issue ?

Do you need help ?

@makasim Does someone work on this issue ?

Unfortunately, no one I am aware of.
I don't plan working on it too.

It's not a code issue, but rather a service required for testing fails to start :/

@Steveb-p @makasim based on Dockerfile I've created locally simple stack:

services:
 thruway:
 build: .

and after docker-compose up -d I see that thruway service exits with 255 status. Looking at container's logs I see:

rnd-thruway-1 | PHP Fatal error: Declaration of Thruway\Logging\ConsoleLogger::log($level, $message, array $context = []) must be compatible with Psr\Log\AbstractLogger::log($level, Stringable|string $message, array $context = []): void in /thruway/vendor/thruway/client/src/Logging/ConsoleLogger.php on line 22

So the root cause of failed jobs is voryx/thruway used in makasim/nginx-php-fpm:latest-all-exts image. Probably not compatible with PHP8 or Composer dependencies are not resolved correctly.

I'm going to work on this issue.

2 fixes are possible:

• Use the PHP 7.4 version of the docker makasim/nginx-php-fpm:latest-all-exts image instead of the latest.
• Fix the issue in the Thruway\Logging\ConsoleLogger class in the thruway/client package

I've just opened a PR (#1237) to fix the CI on the master branch.

According to my fork, it should be OK: https://github.com/jdecool/enqueue-dev/actions/runs/1791778929.

@makasim since this is a simple change I'm taking the liberty of merging it.

Thanks