Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Set to Header only Headers #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
s1lver wants to merge 1 commit into php-enqueue:master from s1lver:fix_convert_context

Conversation

Copy link

@s1lver s1lver commented Oct 25, 2021

I`m setting headers and properties

Снимок экрана 2021年10月25日 в 17 13 04

If i use function $message->getHeaders() i get properties instead and if use $message->getProperties() i get headers!!!

This PR fixing it

Before fix

{"headers":{"delivery_mode":1,"user_id":"guest"}}

After fix

{"headers":{"traceparent":"00-4bf92f3577b34da6a3ce929d0e0e4736-00f067aa0ba902b7-01","z-traceparent":"dsjdhsjdhsjds"}}

pozitronik reacted with thumbs up emoji
Copy link
Member

makasim commented Nov 23, 2021

This would be a huge BC break. There are a lot of projects which rely on current behavior, even though it's not correct.

Copy link
Author

s1lver commented Nov 30, 2021

This would be a huge BC break. There are a lot of projects which rely on current behavior, even though it's not correct.

Maybe add a description to UPGRADE.md?

Copy link
Member

makasim commented Nov 30, 2021
edited
Loading

That would require a version bump and a lot of work on my side. I'd prefer to avoid it.

Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 16, 2022
@stale stale bot closed this Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /