Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Split tests into different matrices; fix highest/lowest dependencies #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
makasim merged 27 commits into php-enqueue:master from andrewmy:fix-matrix-2
Feb 20, 2021

Conversation

Copy link
Contributor

@andrewmy andrewmy commented Feb 11, 2021 •
edited
Loading

The original build matrix looked quite funky, trying to make it more understandable and expandable here.

Also recently I encountered bugs in a different library which had quite wide lowest/highest deps gap, made me think we should test it here as well.

  • Split tests into different matrices;
  • Add highest/lowest dependencies;
  • Fix lowest dependency versions;
  • Drop Symfony 4.3 and 5.0 tests;
  • Fix composer install race condition in CI.

@andrewmy andrewmy changed the title (削除) Split tests into different matrices (削除ここまで) (追記) Split tests into different matrices; fix highest/lowest dependencies (追記ここまで) Feb 11, 2021
Copy link
Contributor Author

Turns out bunny 0.2 had open php req and "allowed" php 8 🙈 Discovered it while bumping react libs to ^1.0.
Had to fix the bunny requirement here which duplicates #1143 — happy to have it merged first if it happens so.
snapshotpl reacted with thumbs up emoji

Copy link
Contributor Author

The matrix is huge :o
Symfony 4.3 and 5.0 are EOL — do we want to test against them? See https://symfony.com/releases

Copy link
Contributor Author

andrewmy commented Feb 18, 2021 •
edited
Loading

@makasim @Steveb-p now the PR is ready to go, sorry for not making it a draft initially.
I've still got a question about EOL Symfony versions though, see above.

Copy link
Member

makasim commented Feb 18, 2021

Symfony 4.3 and 5.0 are EOL — do we want to test against them? See https://symfony.com/releases

I dont think so.
snapshotpl and andrewmy reacted with thumbs up emoji

Copy link
Contributor Author

Looks ready to me now, and also fixes the composer install race condition which may impact other PRs

@makasim makasim merged commit ad8b334 into php-enqueue:master Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makasim makasim makasim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants

AltStyle によって変換されたページ (->オリジナル) /