-
Notifications
You must be signed in to change notification settings - Fork 440
Add PHP 8 #1132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP 8 #1132
Conversation
b26c704
to
66f85f3
Compare
This reverts commit d38fc1d.
This reverts commit 33208da.
33208da
to
480eef5
Compare
Mkay all green now, just waiting for a merge and release from richardfullmer/php-rabbitmq-management-api#11
If a week more goes by, maybe we could switch to a fork?
I am fine with a fork and a comment on why it was needed.
I've tagged a release of php-rabbitmq-management-api in my fork. Since I expect the original author to respond in observable future, I chose the temporary fork route, not publishing the fork on packagist.
Where do I put the comment you mentioned @makasim?
Else this appears to be ready to roll 🚀
I've tagged 0.10.8. @andrewmy big thank you for your work. Don't you mind my mentioning you on twitter ? Do you have one ?
Thanks for the merge! I'm @Andr on Twitter
@makasim can't see neither the new tag nor release here 😅
yeap, false alarm. the script failed.
++ ./bin/splitsh-lite --prefix=pkg/amqp-lib
0 commits created, 0 commits traversed, in 0s
+ SHA1=e9b77b8ab49cd30e18347250f67323a066060fcd
+ git push amqp-lib e9b77b8ab49cd30e18347250f67323a066060fcd:refs/heads/master
ssh_dispatch_run_fatal: Connection to 140.82.121.3 port 22: Operation timed out
fatal: Could not read from remote repository.
not sure what is going on there, the bin/subtree-split.sh
command has been working for ages.
Jurigag
commented
Feb 17, 2021
@makasim where exactly is this 0.10.8 tagged? Doesn't see it on github anywhere.
Now, all is good
Uh oh!
There was an error while loading. Please reload this page.
Currently blocked by:
(削除) or PHP8 support doctrine/DoctrineMongoDBBundle#665 (削除ここまで)—(削除) almost (削除ここまで)green 😬(削除) using a fork for testing (削除ここまで)v4.3 🎉(削除) , waiting for merge, using a fork for testing (削除ここまで)v5 🎉;php: ^7.0
); CI installs 4.2.2 as it has an open PHP version constraint (>=5.5.0
) 😂7.3
tag for the docker image :D Add PHP 8.0 build makasim/docker-nginx-php-fpm#2 (comment)Notes:
(削除) ODM bundle v4.3.x won't work with Symfony 4.3, not sure if affects anyone once we can specifyall g^3.5|^4.3
for the bundle again (削除ここまで)(削除) formapro (削除ここまで)makasim base atmFixes #1108
Fixes #1123