Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add PHP 8 #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
makasim merged 44 commits into php-enqueue:master from andrewmy:add-php-8-2
Feb 17, 2021
Merged

Add PHP 8 #1132

makasim merged 44 commits into php-enqueue:master from andrewmy:add-php-8-2
Feb 17, 2021

Conversation

Copy link
Contributor

@andrewmy andrewmy commented Jan 25, 2021
edited
Loading

Currently blocked by:

Notes:

  • (削除) ODM bundle v4.3.x won't work with Symfony 4.3, not sure if affects anyone once we can specify ^3.5|^4.3 for the bundle again (削除ここまで) all g
  • Not sure how to handle enqueue/dev docker image pushing, building from (削除) formapro (削除ここまで) makasim base atm

Fixes #1108
Fixes #1123

WissameMekhilef, someniatko, floranpagliai, Steveb-p, and leonardinius reacted with thumbs up emoji martinssipenko, RobertV-V-V, kpicaza, floranpagliai, and leonardinius reacted with heart emoji snapshotpl, kpicaza, floranpagliai, Steveb-p, and leonardinius reacted with rocket emoji necromant2005, floranpagliai, WissameMekhilef, and leonardinius reacted with eyes emoji
andrewmy added 27 commits February 9, 2021 11:38
Copy link
Contributor Author

andrewmy commented Feb 9, 2021

Mkay all green now, just waiting for a merge and release from richardfullmer/php-rabbitmq-management-api#11

If a week more goes by, maybe we could switch to a fork?

someniatko, WissameMekhilef, and floriangaerber reacted with thumbs up emoji floranpagliai and Adrians-G reacted with rocket emoji

Copy link
Member

makasim commented Feb 10, 2021

I am fine with a fork and a comment on why it was needed.

@andrewmy andrewmy marked this pull request as ready for review February 16, 2021 21:18
Copy link
Contributor Author

I've tagged a release of php-rabbitmq-management-api in my fork. Since I expect the original author to respond in observable future, I chose the temporary fork route, not publishing the fork on packagist.

Where do I put the comment you mentioned @makasim?

Else this appears to be ready to roll 🚀

@makasim makasim merged commit 18e9444 into php-enqueue:master Feb 17, 2021
Copy link
Member

makasim commented Feb 17, 2021

I've tagged 0.10.8. @andrewmy big thank you for your work. Don't you mind my mentioning you on twitter ? Do you have one ?

Copy link
Contributor Author

Thanks for the merge! I'm @Andr on Twitter ☺️

Copy link
Contributor Author

@makasim can't see neither the new tag nor release here 😅

Copy link
Member

makasim commented Feb 17, 2021

yeap, false alarm. the script failed.

Copy link
Member

makasim commented Feb 17, 2021

++ ./bin/splitsh-lite --prefix=pkg/amqp-lib
0 commits created, 0 commits traversed, in 0s
+ SHA1=e9b77b8ab49cd30e18347250f67323a066060fcd
+ git push amqp-lib e9b77b8ab49cd30e18347250f67323a066060fcd:refs/heads/master
ssh_dispatch_run_fatal: Connection to 140.82.121.3 port 22: Operation timed out
fatal: Could not read from remote repository.

not sure what is going on there, the bin/subtree-split.sh command has been working for ages.

Copy link

Jurigag commented Feb 17, 2021

@makasim where exactly is this 0.10.8 tagged? Doesn't see it on github anywhere.

Copy link
Member

makasim commented Feb 17, 2021

Now, all is good

andrewmy, downace, markstory, and someniatko reacted with hooray emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makasim makasim makasim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflict between symfony/cache and php-enqueue/job-queue PHP 8 Support?

AltStyle によって変換されたページ (->オリジナル) /