Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updates and adds missing documents #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ptejada wants to merge 1 commit into php-censor:master from ptejada:master

Conversation

Copy link
Contributor

@ptejada ptejada commented Jan 30, 2019

Contribution type

Documentation update

Description of the change

Updates links in the documentation, wording and adds missing documents.

corpsee reacted with heart emoji
Copy link
Member

corpsee commented Jan 30, 2019

@ptejada Thank you for the awesome work! Could you move your branch ahead release-1.0 instead of master please?

Copy link
Contributor Author

ptejada commented Jan 30, 2019 via email

I am not sure what i need to do here. From Mobile
...
On Wed, Jan 30, 2019, 6:19 AM Dmitry Khomutov ***@***.*** wrote: @ptejada <https://github.com/ptejada> Thank you for the awesome work! Could you move your branch ahead release-1.0 instead of master please? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#267 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPd3dY9OlDl1ESbSAbN_OrqlzoXZXfJks5vIX_dgaJpZM4aZbeo> .

Copy link
Member

corpsee commented Jan 30, 2019

It doesn't matter. I merged your changes manually. Thanks!

Copy link
Contributor Author

ptejada commented Jan 30, 2019

Thank you. I am curious why you can't just merge the PR? When creating the PR it says whether it can be merged without any conflicts or not and there weren't any conflicts.

Copy link
Member

corpsee commented Jan 30, 2019

Because I should first merge your branch into release-1.0 and next release-1.0 into master.

Copy link
Member

corpsee commented Jan 31, 2019
edited
Loading

@ptejada I had little time yesterday so I did not write a detailed explanation.

Now stable version is 1.0, which is located in the release-1.0 branch. And master branch is the future version 1.1. And the changes should merge consistently into all branches starting from the smaller version to the larger version.

For example, if we have branches: master (future 2.0 release), release-1.1 (releases 1.1.0, 1.1.1 etc.) and release 1.0, and we have a bugfix (feature) that is relevant for release 1.1, then we need to merge bugfix into a release-1.1 branch, then release-1.1 into master branch.

See Symfony git log, for example. There you can clearly see how the changes merge into all parallel releases sequentially in one direction.

Copy link
Member

corpsee commented Feb 2, 2019

Released with 1.0.4.

@corpsee corpsee removed this from the Version 1.0.* (patch) milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /