-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(UI): animate activated link hint (scale + fade-out) before cleanup #4767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
geekbrother
wants to merge
1
commit into
philc:master
from
geekbrother:feat/activated_hint_animation
Open
feat(UI): animate activated link hint (scale + fade-out) before cleanup #4767
geekbrother
wants to merge
1
commit into
philc:master
from
geekbrother:feat/activated_hint_animation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
geekbrother
commented
Sep 21, 2025
cc @philc @philg-dev for a review 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a brief animation to the activated hint: it scales up and fades out while non-activated hints are hidden immediately.
Hint markers are removed only after the animation completes.
Motivation
Provides clearer visual confirmation of the chosen hint and improves perceived polish without impacting interaction speed.
User-facing behavior
Testing
Open any page, trigger hints (f), choose a hint: activated marker should scale+fade while others hide immediately; markers should then be removed.
Validate no lingering elements or pointer-event issues post-animation.
vimium-fadeout