-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix forward word/vimword behaviors in caret mode #4312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @twio142, I tried this PR and it does fix the issue where "w" does not move forward a word in caret mode. I haven't looked at the code in mode_visual.js -- it's in need of cleanup. From what I can tell from your diff, it looks like "move forward" was simply never implemented? Why does move backward work without the need to branch on alterMethod=="move"?
twio142
commented
Sep 26, 2023
Why does move backward work without the need to branch on alterMethod=="move"?
That's because for forward moving was this character-by-character strategy implemented.
While for backward moving it's just using this universal method: this.selection.modify(this.alterMethod, direction, granularity);
mistog4n
commented
Sep 12, 2024
Just wondering if this could be merged at some point?
No description provided.