-
Notifications
You must be signed in to change notification settings - Fork 105
Implement a fix for #66, excessive memory use in siphon.#67
Open
floren wants to merge 1 commit intopeterbourgon:master from
Open
Implement a fix for #66, excessive memory use in siphon. #67floren wants to merge 1 commit intopeterbourgon:master from
floren wants to merge 1 commit intopeterbourgon:master from
Conversation
The siphon will now stop writing to its internal buffer once the size of the buffer exceeds the maximum cache size. Because we write until we *exceed* the max cache size, we're safe to attempt the cache update even if the buffer only contains partial data, because it's still over the limit & will be rejected.
Owner
peterbourgon
commented
Aug 19, 2021
Would it be smarter to check both d.CacheSizeMax and fi.Size in readWithRLock, and only create and use the siphon if the file size could conceivably fit in the cache?
moraouf11
commented
Dec 26, 2025
@peterbourgon can't we combine both approaches ?
the approach in the PR is good as it saves the memory even if the memory metadata is not accurate or writes was done during the read , while your suggestion can save doing the work to begin with?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The siphon will now stop writing to its internal buffer once the size of the buffer
exceeds the maximum cache size. Because we write until we exceed the max cache size,
we're safe to attempt the cache update even if the buffer only contains partial data,
because it's still over the limit & will be rejected.