-
Notifications
You must be signed in to change notification settings - Fork 0
fix(vibrant-component): ensure column names are only pushed for full data selection in Table#1036
Merged
Merged
fix(vibrant-component): ensure column names are only pushed for full data selection in Table #1036duke-101 merged 2 commits into
duke-101 merged 2 commits into
Conversation
...data selection in Table
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures that column names are only pushed when a full data selection is performed in the table components.
- Added a conditional check in Table.tsx to push column names only when all rows are selected.
- Applied the same logic in VirtualizedTable.tsx for consistency.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/vibrant-components/src/lib/Table/Table.tsx | Encloses pushing of column names within a full data selection check. |
| packages/vibrant-components-web/src/lib/VirtualizedTable/VirtualizedTable.tsx | Mirrors the change in Table.tsx to ensure full data selection before pushing column names. |
bae-unidev
bae-unidev
approved these changes
May 21, 2025
bae-unidev
bae-unidev
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2025年05月20日.10.57.03.mov