-
Notifications
You must be signed in to change notification settings - Fork 3
[ADD] typescript support#20
Open
victormarquess11 wants to merge 2 commits intopatrickpissurno:master from
Open
[ADD] typescript support #20victormarquess11 wants to merge 2 commits intopatrickpissurno:master from
victormarquess11 wants to merge 2 commits intopatrickpissurno:master from
Conversation
Author
victormarquess11
commented
May 20, 2024
resolves #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add typescript support.
Just a index.d.ts file so when the library is imported in a typescript project it will not have the error
"Could not find a declaration file for module 'sqlutils/pg'.
'path/to/folder/node_modules/sqlutils/pg/index.js' implicity has any type."
I had doubts about the Transformation function return type, so I suggest checking if it's correct before merging.